Menu icon Foundation

Developer | SF Bay Area, CA

I develop cool things for the Web & Mac

joeworkman http://joeworkman.net/

My Posts

  • 6
    Replies
  • Mimic prod build from source

    By Joe Workman

    Gruntbuild

    I tend to pull down the latest and greatest from the master branch and build my own version from the source. However, I have noticed that when I run `grunt build` the version that gets build is slightly different then the packaged version the you get from... (continued)

    Last Reply by Rafi Benkual over 3 years ago

My Comments

Joe Workman commented on John's post over 2 years

Why have different repositories? Simply maintain a develop and master branches in your git repo. Piece of cake!

Learn git flow... you development workflow will never be the same!

http://nvie.com/posts/a-successful-git-branching-model/
https://www.atlassian.com/git/tutorials/comparing-workflows/gitflow-workflow

Helpful 1
Joe Workman commented on Rafi Benkual's post over 3 years

I should have done this before Orbit got to this point. I submitted a Pull Request that brings Orbit back to its former glory (pre-5.2).

I reverted the code base back to 5.1.1 and then went through all of the commits since and added most new features and pertinent bug fixes that have been committed since then.

I hope that this fixes most people's issues. It fixes all of mine. :-)

https://github.com/zurb/foundation/pull/5308

Helpful 2
Joe Workman commented on P's post over 3 years

Since you are trying to change the background image, why don't you just use media queries and do it all via CSS. I don't think that interchange is the correct solution here.

Helpful 0
Joe Workman commented on Joe Workman's post over 3 years

So I just did a fresh build from master... Just looking at the CSS, foundation.css is 4728 lines of code. However, in the official 5.2.2 download of foundation.css, there is 5264 lines of code.

I would expect potentially a few lines different since there have been extra commits since 5.2.2 launch. However, 500+ lines seems way off.

Helpful 0
Joe Workman commented on Joe Workman's post over 3 years

Scratch that... It looks like the discrepancies that I was seeing were actual bugs that someone has now fixed. I was seeing a ton of vendor prefixes completely removed.

At some point, someone went gang busters on vendor prefixes in the CSS. This broke a ton of stuff! I looks like a lot of the issues that I was seeing have been resolved.

Helpful 0
Joe Workman commented on Rafi Benkual's post over 3 years

I should add that I don't think that Cloudflare is the only thing that you should do. Email confirmation will definitely slow the spam down considerably. But it definitely will not stop it.

I also think that the report/spam button is a good idea as well. You may want to think about allowing more moderators on the forums that would have to ability to act on those spam reports.

Helpful 0
Joe Workman commented on Rafi Benkual's post over 3 years

I swear by Cloudflare! Its an awesome service... The moment that I started using them, the number of malicious issues that I had with websites basically went to nil.

Helpful 0
Joe Workman commented on Peter Keizer's post over 3 years

You will need to use the variable_height option in Orbit. 

<ul data-orbit data-options="variable_height:true;">
...
</ul>

Helpful 1
Joe Workman commented on Luca Spanò's post over 3 years

My pull request to fix this just got merged into the master branch! Should be all fixed now... https://github.com/zurb/foundation/pull/4795

Helpful 0
Joe Workman commented on Cesc Vilanova's post over 3 years

Don't forget to set to display:block!

img.orbit_img {
    display:block;
    margin: 0 auto;
}

Helpful 1

Posts Followed

Following

    No Content

Followers

My Posts

My Comments

You commented on John's post over 2 years

Why have different repositories? Simply maintain a develop and master branches in your git repo. Piece of cake!

Learn git flow... you development workflow will never be the same!

http://nvie.com/posts/a-successful-git-branching-model/
https://www.atlassian.com/git/tutorials/comparing-workflows/gitflow-workflow

Helpful 1
You commented on Rafi Benkual's post over 3 years

I should have done this before Orbit got to this point. I submitted a Pull Request that brings Orbit back to its former glory (pre-5.2).

I reverted the code base back to 5.1.1 and then went through all of the commits since and added most new features and pertinent bug fixes that have been committed since then.

I hope that this fixes most people's issues. It fixes all of mine. :-)

https://github.com/zurb/foundation/pull/5308

Helpful 2
You commented on P's post over 3 years

Since you are trying to change the background image, why don't you just use media queries and do it all via CSS. I don't think that interchange is the correct solution here.

Helpful 0
You commented on Joe Workman's post over 3 years

So I just did a fresh build from master... Just looking at the CSS, foundation.css is 4728 lines of code. However, in the official 5.2.2 download of foundation.css, there is 5264 lines of code.

I would expect potentially a few lines different since there have been extra commits since 5.2.2 launch. However, 500+ lines seems way off.

Helpful 0
You commented on Joe Workman's post over 3 years

Scratch that... It looks like the discrepancies that I was seeing were actual bugs that someone has now fixed. I was seeing a ton of vendor prefixes completely removed.

At some point, someone went gang busters on vendor prefixes in the CSS. This broke a ton of stuff! I looks like a lot of the issues that I was seeing have been resolved.

Helpful 0
You commented on Rafi Benkual's post over 3 years

I should add that I don't think that Cloudflare is the only thing that you should do. Email confirmation will definitely slow the spam down considerably. But it definitely will not stop it.

I also think that the report/spam button is a good idea as well. You may want to think about allowing more moderators on the forums that would have to ability to act on those spam reports.

Helpful 0
You commented on Rafi Benkual's post over 3 years

I swear by Cloudflare! Its an awesome service... The moment that I started using them, the number of malicious issues that I had with websites basically went to nil.

Helpful 0
You commented on Peter Keizer's post over 3 years

You will need to use the variable_height option in Orbit. 

<ul data-orbit data-options="variable_height:true;">
...
</ul>

Helpful 1
You commented on Luca Spanò's post over 3 years

My pull request to fix this just got merged into the master branch! Should be all fixed now... https://github.com/zurb/foundation/pull/4795

Helpful 0
You commented on Cesc Vilanova's post over 3 years

Don't forget to set to display:block!

img.orbit_img {
    display:block;
    margin: 0 auto;
}

Helpful 1

Posts Followed

Following

  • No Content

Followers

Download ZURB’s 17 Responsive Trends That Will Shape 2017

Stay informed with amazing responsive trends each month from ZURB.
Register Today

Get all the answers in our
Foundation Classes

Learn Foundation from the creators in our interactive online webinars which will keep you up to date with the latest trends and skills needed to win your projects.

Or if you prefer, contact the Foundation Team at training@zurb.com or (408) 341-0600 x635