Menu icon Foundation

My Posts




My Comments

Glenn Korban commented on Chris Williams's post over 5 years

I'm having the same issue.

Glenn Korban commented on Glenn Korban's post over 5 years

Looks like echee beat me to the punch.
https://github.com/zurb/foundation/issues/4726

Glenn Korban commented on Peter Hicks's post over 5 years

The next_on_click setting was merged in commit 25592328383918f2a5896d9cb6935e94b66741cf (Feb 26) then removed in commit 61fac2ef67a87f4d535cba0f819fc57aa2adaf24 (Mar 4). I assume the latter was accidental since it wasn't removed from the docs.

I submitted a pull request to add it back in.
https://github.com/zurb/foundation/pull/4716

Glenn Korban commented on Luca Spanò's post over 5 years

Luca, Rafi,

Please check out the following pull request (to add 'next_on_click' setting) and let me know if it does the trick for you:

https://github.com/zurb/foundation/pull/4553

Glenn Korban commented on Pooria Khodaveissi's post over 5 years

Pooria,
I expanded on Sander Schouten's suggestion and added a 'next_on_click' setting that conditionally removes the behavior.

You can check out the code here:
https://github.com/gkorban/foundation/tree/4387

Pull request:
https://github.com/zurb/foundation/pull/4553

Please check it out and let me know if it works for you (or doesn't)

Glenn Korban commented on Glenn Korban's post over 5 years

Looks like the tests for pull request 4467 failed. I just submitted a similar pull request (https://github.com/zurb/foundation/pull/4553), but added the 'next_on_click' setting so the behavior can be conditionally disabled instead of removed entirely.

Glenn Korban commented on Glenn Korban's post over 5 years

Thanks!

Glenn Korban commented on Glenn Korban's post over 5 years

I also just noticed the height isn't initializing correctly, until I resize the window.

Posts Followed








Following

    No Content

Followers

My Posts

My Comments

You commented on Chris Williams's post over 5 years

I'm having the same issue.

You commented on Glenn Korban's post over 5 years

Looks like echee beat me to the punch.
https://github.com/zurb/foundation/issues/4726

You commented on Peter Hicks's post over 5 years

The next_on_click setting was merged in commit 25592328383918f2a5896d9cb6935e94b66741cf (Feb 26) then removed in commit 61fac2ef67a87f4d535cba0f819fc57aa2adaf24 (Mar 4). I assume the latter was accidental since it wasn't removed from the docs.

I submitted a pull request to add it back in.
https://github.com/zurb/foundation/pull/4716

You commented on Luca Spanò's post over 5 years

Luca, Rafi,

Please check out the following pull request (to add 'next_on_click' setting) and let me know if it does the trick for you:

https://github.com/zurb/foundation/pull/4553

You commented on Pooria Khodaveissi's post over 5 years

Pooria,
I expanded on Sander Schouten's suggestion and added a 'next_on_click' setting that conditionally removes the behavior.

You can check out the code here:
https://github.com/gkorban/foundation/tree/4387

Pull request:
https://github.com/zurb/foundation/pull/4553

Please check it out and let me know if it works for you (or doesn't)

You commented on Glenn Korban's post over 5 years

Looks like the tests for pull request 4467 failed. I just submitted a similar pull request (https://github.com/zurb/foundation/pull/4553), but added the 'next_on_click' setting so the behavior can be conditionally disabled instead of removed entirely.

You commented on Glenn Korban's post over 5 years

Thanks!

You commented on Glenn Korban's post over 5 years

I also just noticed the height isn't initializing correctly, until I resize the window.

Posts Followed

Following

  • No Content

Followers

  • No Content