Menu icon Foundation

My Posts




My Comments

Travis Fulton commented on Travis Fulton's post over 3 years

Thanks for the reply, however my gulpfile.babel.js file is laid out differently than the gulpfile in your other post. I understand that I need to point to the plugin file in bower_components, I'm just unsure of the syntax. Thanks!
 
function javascript() {
  return gulp.src(PATHS.javascript)
    .pipe($.sourcemaps.init())
    .pipe($.babel())
    .pipe($.concat('app.js'))
    .pipe($.if(PRODUCTION, $.uglify()
      .on('error', e => { console.log(e); })
    ))
    .pipe($.if(!PRODUCTION, $.sourcemaps.write()))
    .pipe(gulp.dest(PATHS.dist + '/assets/js'));
}
 
foundation 6.2.1

Travis Fulton commented on Travis Fulton's post almost 4 years

Excellent, thank you Brandon.

Travis Fulton commented on Max Drake's post almost 4 years

Hmmm, are you using Foundation 6 with all the partials stuff? Sounds fishy that the 'stray' closing div would fix it and not break anything else if it really were a stray. By the way, the
HTML
</div>

doesn't show on this forum post, but does on Outlook (which is how I know what you're talking about.)

Grab the source of the page (the final code that gets generated) and run it through https://validator.w3.org/ with and without the stray. That will tell you for sure if it belongs there or not. If you're on a mac in Chrome opt+cmd+u will bring up the source code.

Good luck!

Travis Fulton commented on Max Drake's post almost 4 years

Yeah, it's just hard not seeing the code/site itself. Sounds like there's some extra div that's wrapping the footer that has a width applied to it. Make sure that the footer is truly on it's own.

Travis Fulton commented on Max Drake's post almost 4 years

Inspect the first section with a green background that says, "Banking for Innovation" under the main image on this site:
https://innovation.firstrepublic.com/

You'll see that I have .bg-green wrapped around a .row with just a background set.
You may have something else going on if this isn't immediately working for you. Do you have your project up anywhere?

Travis Fulton commented on Max Drake's post almost 4 years

Just wrap another div around .row and apply a background color to that.

Travis Fulton commented on Ryan Hayden's post almost 4 years

Tim and Ryan, are you experiencing the same issue as me? Seems like there should be a note explaining that you may have to restart gulp to see changes in framework files.
http://foundation.zurb.com/forum/posts/37589-cli-installed-f611-doesnt-update-panini-changes-in-dist

Travis Fulton commented on hector_sapien's post almost 4 years

bower_components/foundation-sites/bower.json

Travis Fulton commented on Robocop's post almost 4 years

Gmail strips out styles in the head, thus the media queries (which live in the head) controlling the visibility classes aren't going to work for gmail. This is noted in the docs. http://foundation.zurb.com/emails/docs.html

Posts Followed





Following

    No Content

Followers

My Posts

My Comments

You commented on Travis Fulton's post over 3 years

Thanks for the reply, however my gulpfile.babel.js file is laid out differently than the gulpfile in your other post. I understand that I need to point to the plugin file in bower_components, I'm just unsure of the syntax. Thanks!
 
function javascript() {
  return gulp.src(PATHS.javascript)
    .pipe($.sourcemaps.init())
    .pipe($.babel())
    .pipe($.concat('app.js'))
    .pipe($.if(PRODUCTION, $.uglify()
      .on('error', e => { console.log(e); })
    ))
    .pipe($.if(!PRODUCTION, $.sourcemaps.write()))
    .pipe(gulp.dest(PATHS.dist + '/assets/js'));
}
 
foundation 6.2.1

You commented on Travis Fulton's post almost 4 years

Excellent, thank you Brandon.

You commented on Max Drake's post almost 4 years

Hmmm, are you using Foundation 6 with all the partials stuff? Sounds fishy that the 'stray' closing div would fix it and not break anything else if it really were a stray. By the way, the
HTML
</div>

doesn't show on this forum post, but does on Outlook (which is how I know what you're talking about.)

Grab the source of the page (the final code that gets generated) and run it through https://validator.w3.org/ with and without the stray. That will tell you for sure if it belongs there or not. If you're on a mac in Chrome opt+cmd+u will bring up the source code.

Good luck!

You commented on Max Drake's post almost 4 years

Yeah, it's just hard not seeing the code/site itself. Sounds like there's some extra div that's wrapping the footer that has a width applied to it. Make sure that the footer is truly on it's own.

You commented on Max Drake's post almost 4 years

Inspect the first section with a green background that says, "Banking for Innovation" under the main image on this site:
https://innovation.firstrepublic.com/

You'll see that I have .bg-green wrapped around a .row with just a background set.
You may have something else going on if this isn't immediately working for you. Do you have your project up anywhere?

You commented on Max Drake's post almost 4 years

Just wrap another div around .row and apply a background color to that.

You commented on Ryan Hayden's post almost 4 years

Tim and Ryan, are you experiencing the same issue as me? Seems like there should be a note explaining that you may have to restart gulp to see changes in framework files.
http://foundation.zurb.com/forum/posts/37589-cli-installed-f611-doesnt-update-panini-changes-in-dist

You commented on hector_sapien's post almost 4 years

bower_components/foundation-sites/bower.json

You commented on Robocop's post almost 4 years

Gmail strips out styles in the head, thus the media queries (which live in the head) controlling the visibility classes aren't going to work for gmail. This is noted in the docs. http://foundation.zurb.com/emails/docs.html

Posts Followed

Following

  • No Content

Followers

  • No Content