Menu icon Foundation

Designer

My Posts

No Content

My Comments

Brandon Barringer commented on Bryan Zmijewski's post over 3 years

@Glenn @Rafi
 
Looks like I had added ids to the list of ignored attributes. If that is removed, the ids should be passed without issue. Maybe this can be changed for the next release? I'm not sure why I had added that to the ignored attributes in the first place. 
@Glenn for now you can go into your node_modules/inky/lib/util/getAttrs.js and remove id from the ignoredAttributes array as a work around.
Full Disclosure: I have not tested the impact of removing this snippet of code, any edits to core will be overwritten if the framework is updated. I don't think it will be an issue, but you never know :-)

Brandon Barringer commented on Bryan Zmijewski's post over 3 years

@Rafi I use Panini to add all the content for each module so who ever is working on a new template just has to edit a JSON file that looks like this:
{
"content":
[
{
"imageSrc": "http://placehold.it/360x250",
"imageWidth": 580,
"headline": "Longer Headlines Seem to Work Better Here",
"link": "http://example.com",
"byline": "By John Doe",
"description": "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Donec gravida semper neque, eu molestie ex varius ac. Curabitur ut quam aliquam."
}
]
}
This way, if there are multiple "Contents", the module would repeat itself automatically with the new content instead of having to edit and copy the html

Brandon Barringer commented on Bryan Zmijewski's post over 3 years

@Rafi Yes. That is exactly right. I have not run into any issues with the Mailchimp integrations at all. As long as one has a handle on how to properly integrate into those systems there are no problems. 
One thing I am looking to improve in the future is figuring out how to have integrations be seamless between the different providers with a single attribute.
I have built a framework for our internal team on top of Foundation for Emails that has pre-built modules that can easily be layed out with help from Panini. What I would like to do is add a single attribute in those modules, something like this:
{{#each module.content}}
<container hide repeat class="module">
<row>
<columns>
<center>
<a edit="module" href="{{link}}"><img width="{{imageWidth}}" src="{{imageSrc}}" alt=""></a>
</center>
</columns>
</row>
</container>
{{/each}}
That will automatically swap out those custom attributes for what ever system one is trying to integrate into using some sort of flag. So for mailchimp those tags would swap out as follows:hide = mc:hideablerepeat = mc:repeatableedit="module" = mc:edit="module"For other systems it would change as needed based on the flag given. 

Brandon Barringer commented on Bryan Zmijewski's post over 3 years

Its funny, when I originally wrote this, my main need for attributes was for integration into Email Management Systems such as Mailchimp. It's great to see that people are finding all sorts of fantastic uses for this feature. 

Posts Followed


Following

    No Content

Followers

My Posts

No Content

My Comments

You commented on Bryan Zmijewski's post over 3 years

@Glenn @Rafi
 
Looks like I had added ids to the list of ignored attributes. If that is removed, the ids should be passed without issue. Maybe this can be changed for the next release? I'm not sure why I had added that to the ignored attributes in the first place. 
@Glenn for now you can go into your node_modules/inky/lib/util/getAttrs.js and remove id from the ignoredAttributes array as a work around.
Full Disclosure: I have not tested the impact of removing this snippet of code, any edits to core will be overwritten if the framework is updated. I don't think it will be an issue, but you never know :-)

You commented on Bryan Zmijewski's post over 3 years

@Rafi I use Panini to add all the content for each module so who ever is working on a new template just has to edit a JSON file that looks like this:
{
"content":
[
{
"imageSrc": "http://placehold.it/360x250",
"imageWidth": 580,
"headline": "Longer Headlines Seem to Work Better Here",
"link": "http://example.com",
"byline": "By John Doe",
"description": "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Donec gravida semper neque, eu molestie ex varius ac. Curabitur ut quam aliquam."
}
]
}
This way, if there are multiple "Contents", the module would repeat itself automatically with the new content instead of having to edit and copy the html

You commented on Bryan Zmijewski's post over 3 years

@Rafi Yes. That is exactly right. I have not run into any issues with the Mailchimp integrations at all. As long as one has a handle on how to properly integrate into those systems there are no problems. 
One thing I am looking to improve in the future is figuring out how to have integrations be seamless between the different providers with a single attribute.
I have built a framework for our internal team on top of Foundation for Emails that has pre-built modules that can easily be layed out with help from Panini. What I would like to do is add a single attribute in those modules, something like this:
{{#each module.content}}
<container hide repeat class="module">
<row>
<columns>
<center>
<a edit="module" href="{{link}}"><img width="{{imageWidth}}" src="{{imageSrc}}" alt=""></a>
</center>
</columns>
</row>
</container>
{{/each}}
That will automatically swap out those custom attributes for what ever system one is trying to integrate into using some sort of flag. So for mailchimp those tags would swap out as follows:hide = mc:hideablerepeat = mc:repeatableedit="module" = mc:edit="module"For other systems it would change as needed based on the flag given. 

You commented on Bryan Zmijewski's post over 3 years

Its funny, when I originally wrote this, my main need for attributes was for integration into Email Management Systems such as Mailchimp. It's great to see that people are finding all sorts of fantastic uses for this feature. 

Posts Followed

Following

  • No Content

Followers

  • No Content